-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add webauthn module #189
Conversation
howydev
commented
Sep 24, 2024
- Add webauthn module
- Rename "SingleSigner" naming -> ECDSA
Summary by OctaneNew Contracts
Updated Contracts
🔗 Commit Hash: 6585ad7 |
Overview
Detailed findings
|
8a19552
to
532bb8a
Compare
Contract sizes: -| Contract | Size (B) | Margin (B) |
-|------------------------------|----------|------------|
-| AccountFactory | 4,169 | 20,407 |
-| AllowlistModule | 5,817 | 18,759 |
-| ERC20TokenLimitModule | 4,138 | 20,438 |
-| ModularAccount | 25,983 | -1,407 |
-| PaymasterGuardModule | 1,718 | 22,858 |
-| SemiModularAccount | 26,487 | -1,911 |
-| SingleSignerValidationModule | 3,444 | 21,132 |
-| TimeRangeModule | 1,870 | 22,706 |
-| TokenReceiverModule | 2,189 | 22,387 |
+| Contract | Size (B) | Margin (B) |
+|--------------------------|----------|------------|
+| AccountFactory | 4,169 | 20,407 |
+| AllowlistModule | 5,817 | 18,759 |
+| ECDSAValidationModule | 3,444 | 21,132 |
+| ERC20TokenLimitModule | 4,138 | 20,438 |
+| ModularAccount | 25,983 | -1,407 |
+| PaymasterGuardModule | 1,718 | 22,858 |
+| SemiModularAccount | 26,487 | -1,911 |
+| TimeRangeModule | 1,870 | 22,706 |
+| TokenReceiverModule | 2,189 | 22,387 |
+| WebauthnValidationModule | 7,854 | 16,722 | Code coverage:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
3176ceb
to
cb57e31
Compare
Not a vuln |
cb57e31
to
8b2e487
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small nit in the test